Submission Details
Severity:
Incorrect event is triggered in BidBeastsNFTMarket::placeBid
Description\
AuctionSettled event is triggered every time in function `BidBeastsNFTMarket::placeBid. That is not correct because actually the auction is not settled yet. This can affect external integrations that rely on events.
function placeBid(uint256 tokenId) external payable isListed(tokenId) {
...
if (listing.buyNowPrice > 0 && msg.value >= listing.buyNowPrice) {
...
return;
}
require(msg.sender != previousBidder, "Already highest bidder");
@> emit AuctionSettled(tokenId, msg.sender, listing.seller, msg.value);
...
}
Risk
Likelihood: High
Event is triggered on every bid.
Impact: Low
It affects only events.
Recommended Mitigation
Remove the event triggering from the function:
- emit AuctionSettled(tokenId, msg.sender, listing.seller, msg.value);
Updates
Lead Judging Commences
cryptoghost about 1 month ago
Submission Judgement Published Assigned finding tags:
BidBeasts Marketplace: Incorrect Event Emission
placeBid emits AuctionSettled even though the auction hasn’t ended, causing misleading event logs.
Rewards breakdown
nSLOC
170This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.