Bid Beasts

First Flight #49
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Submission Details
Severity: low
Valid

Deadline in contest details is not enforced in `BidBeastsNFTMarket` contract - users bidding under wrong assumptions

Root + Impact

Description

  • After 3 days the auction ends and anyone can call endAuctionfunction.

  • There is no deadline enforced in BidBeastsNFTMarketcontract (only an extension of 15 min after every bid) and there is no function called endAuction.


  • Contest details

    1. Auction Completion:

      • After 3 days, anyone can call endAuction(tokenId) to finalize the auction.

    2. The contract also supports:

      • Auction deadline of exactly 3 days.

Risk

Likelihood:

  • The mismatch exists unconditionally - every auction created is affected.


Impact:

  • All users are mislead by contest details vs. on-chain reality.

  • Users will assume the auction ends after 3 days, but in reality the auction ends 15 minutes after last bid.

Proof of Concept

* Contest details
1. Auction completion:
* After 3 days, anyone can call `endAuction(tokenId)` to finalize the auction.
2. The contract also supports:
* Auction deadline of exactly 3 days.

Recommended Mitigation

Change the contest details to say that for every bid that is between minimum price and buy now price the auction duration extends 15 minutes. Then 15 minutes after last bid anyone can call settleAuction.

Updates

Lead Judging Commences

cryptoghost Lead Judge
about 1 month ago
cryptoghost Lead Judge about 1 month ago
Submission Judgement Published
Validated
Assigned finding tags:

BidBeasts Marketplace: Improper Documentation

Documentation for BidBeasts Marketplace is incomplete or inaccurate, potentially leading to misconfigurations or security misunderstandings.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.