Bid Beasts

First Flight #49
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Submission Details
Severity: low
Valid

Inconsistent Logic in Bid Validation

Description

For the first bid, the logic requires msg.value > minPrice. For subsequent bids, the check is msg.value >= previousBid increment. This creates an inconsistency: first bid must be strictly greater, while later bids allow equality.

  • placeBid():

require(msg.value > requiredAmount, "First bid must be > min price");

Risk

Impact:

  • Minor UX confusion for users.

  • A bidder may wonder why their first bid equal to the minimum price is rejected, while equal increments later are accepted.

Recommended Mitigation

Standardize the check across all cases by using >=.

Updates

Lead Judging Commences

cryptoghost Lead Judge about 1 month ago
Submission Judgement Published
Validated
Assigned finding tags:

BidBeasts Marketplace: First Bid > Instead of >=

First bid validation uses > instead of >=, preventing valid starting bids.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.