Bid Beasts

First Flight #49
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Submission Details
Severity: low
Valid

Auction extension duration is set to 15 minutes, contradicting specification.

Root + Impact

Description

  • Normal Behavior: The auction should follow the intended business logic for duration, typically a longer period (e.g., 3 days).

  • Specific Issue: The constant that determines the auction extension period, S_AUCTION_EXTENSION_DURATION, is hardcoded to 15 minutes. This is a severe deviation from the general market expectation for NFT auctions (and often contradicts the specification provided in the contest details).

// Root cause in the codebase with @> marks to highlight the relevant section
uint256 constant public S_AUCTION_EXTENSION_DURATION = @> 15 minutes <@;

Risk

Likelihood:

  • The hardcoded value is guaranteed to be active.

  • Every auction will be affected by this shortened duration.

Impact:

  • Incorrect Business Logic. Undermines the intended user experience and marketing of the auction.

  • Potential for front-running/sniping since the window is very small.

Proof of Concept

This is an informational finding based on the codebase's constant value versus common practice. No exploitation PoC is required, but the fact that the auction ends much faster than expected is provable on the blockchain.


Recommended Mitigation

Verify the intended auction duration with the protocol team and update the constant to reflect the correct business requirement (e.g., 3 days or 72 hours). Assuming the intent was 3 days:

- uint256 constant public S_AUCTION_EXTENSION_DURATION = 15 minutes;
+ uint256 constant public S_AUCTION_EXTENSION_DURATION = 3 days; // Recommended fix to 3 days
Updates

Lead Judging Commences

cryptoghost Lead Judge
about 1 month ago
cryptoghost Lead Judge 29 days ago
Submission Judgement Published
Validated
Assigned finding tags:

BidBeasts Marketplace: Incorrect Event Emission

placeBid emits AuctionSettled even though the auction hasn’t ended, causing misleading event logs.

BidBeasts Marketplace: Improper Documentation

Documentation for BidBeasts Marketplace is incomplete or inaccurate, potentially leading to misconfigurations or security misunderstandings.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.