Bid Beasts
First Flight #49
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Previous Next
Submission Details
Severity: low
Valid

HIGH ISSUE: Wrong Auction Duration

mostafapahlevani93

Root + Impact

Description

  • The auction extension duration is set to 15 minutes instead of the required 3 days according to project specifications.

uint256 constant public S_AUCTION_EXTENSION_DURATION = 15 minutes; // Should be 3 days

Risk

Likelihood:

  • Every auction will have incorrect timing

  • This affects all auction functionality in the contract

  • The discrepancy is permanent due to the constant declaration

Impact:

  • Auctions end much sooner than intended (15 minutes vs 3 days)

  • Users have insufficient time to place competitive bids

  • Contract doesn't meet project requirements

Proof of Concept

function testAuctionDurationTooShort() public {
vm.prank(alice);
marketplace.listNFT(tokenId, 0.1 ether, 0);
vm.prank(bob);
marketplace.placeBid{value: 0.2 ether}(tokenId);
// Auction should last 3 days but only lasts 15 minutes
uint256 auctionEnd = marketplace.getListing(tokenId).auctionEnd;
assertEq(auctionEnd, block.timestamp + 15 minutes); // Wrong!
// Should be: block.timestamp + 3 days
}

Recommended Mitigation

- uint256 constant public S_AUCTION_EXTENSION_DURATION = 15 minutes;
+ uint256 constant public S_AUCTION_EXTENSION_DURATION = 3 days;
Updates

Lead Judging Commences

cryptoghost Lead Judge about 1 month ago
Submission Judgement Published
Validated
Assigned finding tags:

BidBeasts Marketplace: Improper Documentation

Documentation for BidBeasts Marketplace is incomplete or inaccurate, potentially leading to misconfigurations or security misunderstandings.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.