Submission Details
Impact:
Likelihood:
State change without event.
State change without event.
Description
-
There are state variable changes in the
RaiseBoxFaucet.sol::adjustDailyClaimLimit()function but no event is emitted. -
Explain the specific issue or problem in one or more sentences
// This function does not emit an event,
// so it is difficult to track changes in the value of `dailyClaimLimit` off-chain.
function adjustDailyClaimLimit(uint256 by, bool increaseClaimLimit) public onlyOwner {
if (increaseClaimLimit) {
dailyClaimLimit += by;
} else {
if (by > dailyClaimLimit) {
revert RaiseBoxFaucet_CurrentClaimLimitIsLessThanBy();
}
dailyClaimLimit -= by;
}
}
Risk
Likelihood:
This issue uccurs every time the RaiseBoxFaucet.sol::adjustDailyClaimLimit() is executed.
Impact:
RaiseBoxFaucet.sol::adjustDailyClaimLimit() does not emit an event, so it is difficult to track changes in the value of dailyClaimLimit off-chain.
Recommended Mitigation
Consider emitting an event to enable offchain indexers to track the changes.
// -----------------------------------------------------------------------
// EVENTS
// -----------------------------------------------------------------------
// . . . .
event Claimed(address indexed user, uint256 amount);
event MintedNewFaucetTokens(address indexed user, uint256 amount);
+event DailyClaimLimitAdjusted(uint256 indexed dailyClaimLimit);
// . . . .
function adjustDailyClaimLimit(uint256 by, bool increaseClaimLimit) public onlyOwner {
if (increaseClaimLimit) {
dailyClaimLimit += by;
} else {
if (by > dailyClaimLimit) {
revert RaiseBoxFaucet_CurrentClaimLimitIsLessThanBy();
}
dailyClaimLimit -= by;
}
+ emit DailyClaimLimitAdjusted(dailyClaimLimit);
}
Rewards breakdown
nSLOC
157This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.