Submission Details
Impact:
Likelihood:
[L-02] Missing Events for Critical Parameter Changes
Description
-
The adjustDailyClaimLimit function modifies the dailyClaimLimit state variable without emitting events, making it difficult to track changes off-chain.
function adjustDailyClaimLimit(uint256 by, bool increaseClaimLimit) public onlyOwner {
if (increaseClaimLimit) {
dailyClaimLimit += by; // <@No event emitted
} else {
if (by > dailyClaimLimit) {
revert RaiseBoxFaucet_CurrentClaimLimitIsLessThanBy();
}
dailyClaimLimit -= by; // <@No event emitted
}
Risk
Low Likelihood:
Doesn't directly enable exploits
** Low Impact** :
-
No direct fund risk, but reduces transparency
· Harder for monitoring tools to track parameter changes
Recommended Mitigation
+ event DailyClaimLimitChanged(uint256 newLimit, uint256 oldLimit);
function adjustDailyClaimLimit(uint256 by, bool increaseClaimLimit) public onlyOwner {
uint256 oldLimit = dailyClaimLimit;
if (increaseClaimLimit) {
dailyClaimLimit += by;
} else {
if (by > dailyClaimLimit) {
revert RaiseBoxFaucet_CurrentClaimLimitIsLessThanBy();
}
dailyClaimLimit -= by;
}
+ emit DailyClaimLimitChanged(dailyClaimLimit, oldLimit);
}
Rewards breakdown
nSLOC
157This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.