Submission Details
Impact:
Likelihood:
Missing event in adjustDailyClaimLimit()
Description
Missing event emission when changing dailyClaimLimit.
Risk
Likelihood: High
No event emitting every time the claim limit is changed.
Impact: Low
Changing limit is important owner action that must be easy to monitor.
Proof of Concept
No event is emitted in the adjustDailyClaimLimit function
function adjustDailyClaimLimit(uint256 by, bool increaseClaimLimit) public onlyOwner {
if (increaseClaimLimit) {
dailyClaimLimit += by;
} else {
if (by > dailyClaimLimit) {
revert RaiseBoxFaucet_CurrentClaimLimitIsLessThanBy();
}
dailyClaimLimit -= by;
}
<@ Should emit event when changing claim limit
}
Recommended Mitigation
Add event in the function.
/// in the events declaration section
+ event RaiseFaucetBox_ClaimLimitChanged(uint256 newLimit);
///
function adjustDailyClaimLimit(uint256 by, bool increaseClaimLimit) public onlyOwner {
if (increaseClaimLimit) {
dailyClaimLimit += by;
} else {
if (by > dailyClaimLimit) {
revert RaiseBoxFaucet_CurrentClaimLimitIsLessThanBy();
}
dailyClaimLimit -= by;
}
+ emit RaiseFaucetBox_ClaimLimitChanged(dailyClaimLimit);
}
Rewards breakdown
nSLOC
157This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.