Submission Details
Impact:
Likelihood:
[L-03] Redundant getter functions increase contract bytecode
Redundant getter functions increase contract bytecode
Description
Getter functions are redundant and are already available via
native balance
inherited functions, i.e.
.owner()fromOwnablestandard ERC20 functions, i.e.
balanceOf()
// Root cause in the codebase with @> marks to highlight the relevant section
function getBalance(address user) public view returns (uint256) {
@> return balanceOf(user);
}
function getFaucetTotalSupply() public view returns (uint256) {
@> return balanceOf(address(this));
}
function getContractSepEthBalance() public view returns (uint256) {
@> return address(this).balance;
}
function getOwner() public view returns (address) {
@> return Ownable.owner();
}
Risk
Impact:
-
Maintenance overhead
-
Additional bytecode size during deployment
-
Confuses developers
Proof of Concept
Add the following tests to your test file:
function test_getters_getBalanceIsRedundant() public view {
assertEq(raiseBoxFaucet.getBalance(user), raiseBoxFaucet.balanceOf(user));
}
function test_getters_getFaucetTotalSupplyIsRedundant() public view {
assertEq(raiseBoxFaucet.getFaucetTotalSupply(), raiseBoxFaucet.balanceOf(address(raiseBoxFaucet)));
}
function test_getters_getContractSepEthBalanceIsRedundant() public view {
assertEq(raiseBoxFaucet.getContractSepEthBalance(), address(raiseBoxFaucet).balance);
}
function test_getters_getOwnerIsRedundant() public view {
assertEq(raiseBoxFaucet.getOwner(), raiseBoxFaucet.owner());
}
Recommended Mitigation
At least getOwner is redundant and confusing. If you want to keep it, call owner() directly.
If necessary, keep getFaucetTotalSupply() , getContractSepEthBalance() and getBalance(address) for easy access.
function getOwner() public view returns (address) {
- return Ownable.owner();
+ return owner();
}
Rewards breakdown
nSLOC
157This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.