Root + Impact / RaiseBoxFaucet.sol::getFaucetTotalSupply function returns contract balance instead of total minted tokens

Description

• Typically, total supply functions return the total number of tokens minted, regardless of which accounts hold them.

• However, the getFaucetTotalSupply function returns the current contract balance instead of the total number of Faucet tokens minted.

Risk

Likelihood:

• The issue occurs each time the getFaucetTotalSupply function is called.

Impact:

• This behavior can lead to user confusion and misinterpretation by external integrations, as the function name suggests it returns the total supply of Faucet tokens.

• Since this function is expected to be used externally, returning the contract’s balance instead of the true total supply may result in inaccurate data being displayed or relied upon.

Proof of Concept

Add the following test to RaiseBoxFaucet.t.sol to reproduce the issue:

Recommended Mitigation

Modify the function to return the actual total supply - i.e., the total number of Faucet tokens minted - instead of the contract’s balance.