BriVault

First Flight #52
Beginner FriendlySolidity
100 EXP
View results
Submission Details
Severity: low
Valid

The main protocol `BriVault` does not prohibit the use of `Weird ERC20` tokens, which may lead to unexpected issues.

The main protocol BriVault does not prohibit the use of Weird ERC20 tokens, which may lead to unexpected issues.

Description

  • The protocol exhibits the following core behaviors:

    • Users deposit funds and wait until the event concludes, after which winners claim their rewards.

  • These behaviors rely on the stability mechanism of the vault asset token to interact correctly with users.

  • However, the protocol does not explicitly prohibit the use of Weird ERC20 tokens as the vault asset token, which may trigger a series of related issues.

Risk

Likelihood:

  • Occurs only if the administrator carelessly selects a Weird ERC20 token as the vault asset token without thorough vetting.

Impact:

  • For example, Fee-on-Transfer or Rebase Tokens deduct fees or adjust balances during transfers, which may cause accounting inconsistencies.

  • For example, Pausable Tokens can be frozen under certain conditions, blocking user interactions with the protocol.

  • Other non-standard ERC20 behaviors may similarly disrupt expected protocol logic.

Proof of Concept

  • N/A

Recommended Mitigation

  • Explicitly state in the protocol documentation that the use of Weird ERC20 tokens as the vault asset token is strictly prohibited.

  • (Optional enhancement) Consider implementing on-chain validation to reject known problematic token types during vault initialization.

Updates

Appeal created

bube Lead Judge 19 days ago
Submission Judgement Published
Validated
Assigned finding tags:

Fee on transfer tokens

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!