Root + Impact

Description

• Normal Behavior:
  The vault should ensure that a user’s net deposit (after deducting participation fees) is at least equal to the minimumAmount.
  In other words, the condition should check whether:

  assets - fee >= minimumAmount

  ​

• Specific Issue:
  The current implementation incorrectly uses the following condition:

  if (minimumAmount + fee > assets) revert lowFeeAndAmount();

  ​

  This logic assumes assets excludes the fee — but in reality, the user’s input (assets) already includes both the deposit and the fee.
  As a result, even valid deposits (e.g., slightly above the minimum) unfairly revert, blocking legitimate users from participating.

Risk

Likelihood:

• High — Every deposit call is affected by this logic error.

• Even correct inputs will revert, especially when the fee is small and the deposit amount is near the minimum threshold.

Impact:

• Denial of Service (DoS): Users cannot participate even with valid amounts.

• Usability Impact: Vault becomes non-functional for deposits close to the minimum threshold.

• Economic Impact: Participants overpay or fail to enter, reducing engagement.

Proof of Concept

Recommended Mitigation

Compare net deposit (after fee deduction) with minimumAmount.