The _getWinnerShares function uses an unbounded for loop which can cause denial of service.

Description

• The _getWinnerShares function uses an unbounded loop, this can hit a gas limit for a transaction when the length of usersAddress is too large considering that the array can contain duplicates. Since the _getWinnerShares internal function is called by the setWinner function for the admin to set the winner, this can cause denial of service.

  function _getWinnerShares() internal returns (uint256) {

  for (uint256 i = 0; i < usersAddress.length; ++i) {

  address user = usersAddress[i];

  totalWinnerShares += userSharesToCountry[user][winnerCountryId];

  }

  return totalWinnerShares;

  }

Risk

Likelihood:

This happens when the usersAddress array is too large.

Impact:

• Causes denial of service

Recommended Mitigation

• Bound the loop to a maximum number to avoid reverts in case the array is long.