BriVault

First Flight #52
Beginner FriendlySolidity
100 EXP
View results
Submission Details
Impact: low
Likelihood: low
Invalid

Missing Events in Constructor

Root + Impact

Description

Normal Behavior:

  • Critical initialization parameters should emit events for transparency and auditability.

Impact:

  • The constructor sets critical parameters (participationFeeBsp, eventStartDate, eventEndDate, participationFeeAddress, minimumAmount) but emits no events.

Risk

Likelihood:

  • Every time the contract is deployed.

Impact:

  • No on-chain record of initial configuration

  • Users must query state variables directly to verify parameters

  • Difficult to audit deployment parameters historically

Recommended Mitigation

constructor (IERC20 _asset, uint256 _participationFeeBsp, uint256 _eventStartDate, address _participationFeeAddress, uint256 _minimumAmount, uint256 _eventEndDate) ERC4626 (_asset) ERC20("BriTechLabs", "BTT") Ownable(msg.sender) {
if (_participationFeeBsp > PARTICIPATIONFEEBSPMAX){
revert limiteExceede();
}
participationFeeBsp = _participationFeeBsp;
eventStartDate = _eventStartDate;
eventEndDate = _eventEndDate;
participationFeeAddress = _participationFeeAddress;
minimumAmount = _minimumAmount;
_setWinner = false;
+ emit VaultInitialized(_asset, _participationFeeBsp, _eventStartDate, _eventEndDate, _participationFeeAddress, _minimumAmount);
}
Updates

Appeal created

bube Lead Judge 19 days ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!