Submission Details
Severity:
Mismatch in Share Minting and Staking Attribution in `deposit` Function
Mismatch in Share Minting and Staking Attribution in deposit Function
Description
-
The deposit function takes the
receiveraddress as an input which is added at all the places, but instead of minting the shares token to thereceiverthe function mints the shares to themsg.sender.
function deposit(uint256 assets, address receiver) public override returns (uint256) {
require(receiver != address(0));
if (block.timestamp >= eventStartDate) {
revert eventStarted();
}
uint256 fee = _getParticipationFee(assets);
// charge on a percentage basis points
if (minimumAmount + fee > assets) {
revert lowFeeAndAmount();
}
uint256 stakeAsset = assets - fee;
stakedAsset[receiver] = stakeAsset;
uint256 participantShares = _convertToShares(stakeAsset);
IERC20(asset()).safeTransferFrom(msg.sender, participationFeeAddress, fee);
IERC20(asset()).safeTransferFrom(msg.sender, address(this), stakeAsset);
@> _mint(msg.sender, participantShares);
emit deposited (receiver, stakeAsset);
return participantShares;
}
Risk
Likelihood:
This will occur every time a user want to enter through an another address or maybe a friends' address
Impact:
If the receiver address' slected team wins then the user might not be able to get the prize money because the shares are minted to the msg.sender address
Recommended Mitigation
- _mint(msg.sender, participantShares);
+ _mint(receiver, participantShares);
Updates
Appeal created
bryanconquer 19 days ago
Submission Judgement Published Assigned finding tags:
Shares Minted to msg.sender Instead of Specified Receiver
Rewards breakdown
nSLOC
193This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.