Submission Details
Impact:
Likelihood:
Missing array length caching in setCountry() loop
The for loop take much gas due to everytime i reads from the storage.
Description
The function iterates through the countries array using countries.length directly inside the loop condition.
However, it does not cache the array length in a local variable (e.g., uint256 len = countries.length;).
function setCountry(string[48] memory countries) public onlyOwner {
@> //uint256 length = countries.length;
for (uint256 i = 0; i < countries.length; ++i) {
teams[i] = countries[i];
}
emit CountriesSet(countries);
}
Risk
Impact:
Each loop iteration re-reads countries.length from memory.
Slight increase in gas cost (minor but measurable).
Reduces clarity and consistency in loop structure.
Recommended Mitigation
This makes the loop slightly cheaper and improves code clarity.
+ function setCountry(string[48] memory countries) public onlyOwner {
+ Uint256 length = countries.length;
- for (uint256 i = 0; i < countries.length; ++i) {
+ for (uint256 i = 0; i < length; ++i) {
teams[i] = countries[i];
}
emit CountriesSet(countries);
}
Updates
Appeal created
bube 19 days ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Gas optimizations
Gas optimizations are invalid according to the CodeHawks documentation.
Rewards breakdown
nSLOC
193This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.