Submission Details
Impact:
Likelihood:
`setCountry::BriVault` function should be made external
Root + Impact : setCountry::BriVault should be made external from public, making the contract more gas efficient.
Description
-
setCountry::BriVaultfunction is usingpublicvisibility specifier but is not used anywhere inside the contract. -
The function should therefore be using
externalspecifier instead ofpublic.
contract BriVault is ERC4626, Ownable {
...
@> function setCountry(string[48] memory countries) public onlyOwner {
for (uint256 i = 0; i < countries.length; ++i) {
teams[i] = countries[i];
}
emit CountriesSet(countries);
}
...
}
Risk
Likelihood: Low
Impact: Low/Gas
This is a gas Optimization.
Recommended Mitigation
It is recommended to change the visibility specifier from
public -> external. Hence, optimizing the gas fee.
contract BriVault is ERC4626, Ownable {
...
- function setCountry(string[48] memory countries) public onlyOwner {
+ function setCountry(string[48] memory countries) external onlyOwner {
for (uint256 i = 0; i < countries.length; ++i) {
teams[i] = countries[i];
}
emit CountriesSet(countries);
}
...
}
Updates
Appeal created
bube 21 days ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Gas optimizations
Gas optimizations are invalid according to the CodeHawks documentation.
Rewards breakdown
nSLOC
193This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.