Submission Details
Impact:
Likelihood:
Gas consumption can be improved saving the array length
Root + Impact
Description
-
In below code the length of the array length is read each time in the loop causing unnesary gas consumption (SLOADs)
@> for (uint256 i = 0; i < usersAddress.length; ++i){
address user = usersAddress[i];
totalWinnerShares += userSharesToCountry[user][winnerCountryId];
}
return totalWinnerShares;
}
Risk
Likelihood:
This will occur each time loop runs.
Impact:
Unnecesary gas consumption
Recommended Mitigation
function _getWinnerShares () internal returns (uint256) {
+ uint256 aLength = usersAddress.length;
- for (uint256 i = 0; i < usersAddress.length; ++i){
+ for (uint256 i = 0; i < aLength; ++i){
address user = usersAddress[i];
totalWinnerShares += userSharesToCountry[user][winnerCountryId];
}
return totalWinnerShares;
}
Updates
Appeal created
bube 19 days ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Gas optimizations
Gas optimizations are invalid according to the CodeHawks documentation.
Rewards breakdown
nSLOC
193This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.