BriVault

First Flight #52
Beginner FriendlySolidity
100 EXP
View results
Submission Details
Impact: low
Likelihood: low
Invalid

`Function:cancelParticipation` lacks checks for stakedAsset

[L-2] Function:cancelParticipation lacks checks for stakedAsset

Description

The cancelParticipation() function allows users to withdraw their staked assets before the event starts. However, the function does not perform sufficient checks before proceeding:

uint256 refundAmount = stakedAsset[msg.sender];
//lacks checks for stakedAsset
stakedAsset[msg.sender] = 0;
uint256 shares = balanceOf(msg.sender);
_burn(msg.sender, shares);
IERC20(asset()).safeTransfer(msg.sender, refundAmount);

Impact

A user with no deposit could still attempt to call the function, wasting gas or triggering revert unexpectedly.

Recommended mitigation

+if (stakedAsset[msg.sender] == 0) revert noDeposit();
Updates

Appeal created

bube Lead Judge 19 days ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!