BriVault

The `setCountry()` function uses an inefficient loop to copy array elements individually, consuming **3,374,149 gas** vs **540,433 gas** for direct assignment.

```solidity

​

@> for (uint256 i = 0; i < countries.length; ++i) {

@> teams[i] = countries[i];

}

​

```

Medium — No direct exploit, but a severe gas inefficiency that can cost hundreds of dollars per execution.

84% gas waste** (2,833,716 excess gas per call)

On Ethereum mainnet at 50 gwei: **~$420 wasted per call**

Unnecessary burden on contract owner

Risk of hitting block gas limit with longer country names

Gas testing shows:

​

setCountry (loop): 3,374,149 gas

setCountryOptimized: 540,433 gas

Savings: 2,833,716 gas (84%)

​

place the following lines of code in your `briVault.t.sol`

​

```solidity

​

function testCompareGas() public {

string[48] memory testCountries;

for(uint i = 0; i < 48; i++) {

testCountries[i] = string(abi.encodePacked("Country", i));

}

vm.prank(owner);

briVault.setCountry(testCountries);

}

​

function testCompareGasOpt() public {

string[48] memory testCountries;

for(uint i = 0; i < 48; i++) {

testCountries[i] = string(abi.encodePacked("Country", i));

}

// Test original (loop version)

vm.prank(owner);

briVault.setCountry(testCountries);

// Test optimized (direct assignment)

vm.prank(owner);

briVault.setCountryOptimized(testCountries);

}

​

```

​

use this forge test prompt `forge test --mt testCompareGas --gas-report` and `forge test --mt testCompareGasOpt --gas-report` to compare the gas cost.

​

​

Replace loop with direct array assignment:

​

```diff

​

}

​

```

​

Note this is for fixed arrays only `teams = countries;` works only for fixed-size arrays `string[48]`.

​

Replace the `setCountry()` function with the `setCountryOptimized()` function.

​

```solidity

}

```