Submission Details
Impact:
Likelihood:
BriVault::getWinner() should have "winnerSet" modifier to prevent premature access
BriVault::getWinner() should have winnerSet modifier to prevent premature access
Description
The getWinner() function can be called even before the event winner is officially set.
This may cause it to return a zero address or an uninitialized value, leading to incorrect assumptions or unintended behavior in dependent functions or frontends.
function getWinner() public view returns (string memory) {
return winner;
}
Risk
Likelihood:
Whenever the
getWinner()function is call even before the event winner is officially set.
Impact:
Causes inconsistent or misleading results.
Recommended Mitigation
Restrict access by adding the winnerSet modifier to ensure getWinner() can only be called after the winner has been determined:
-function getWinner() public view returns (address) {
+function getWinner() public view winnerSet returns (address) {
return winner;
}
Rewards breakdown
nSLOC
193This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.