Unused State Variables (totalAssetsShares, notRegistered) Increase Code Complexity and Gas Overhead

Description

In the BriVault contract, the following state variables are declared but never used anywhere in the contract’s logic or event flow:

Risk

Likelihood:

• This issue always occurs on every contract deployment since the variables are permanently stored on-chain.

• The cost is deterministic: ~20,000 gas per unused storage slot and an increased bytecode size.

Impact:

• Increased gas cost during contract deployment due to additional storage layout.

Proof of Concept

You can verify the absence of references using Foundry’s static analysis:

And by running a quick grep across the codebase:

These commands show only the declaration line, confirming they are not read or written anywhere in the project.

Recommended Mitigation

Remove the variables entirely: