Submission Details
Impact:
Likelihood:
Calldata must be used instead of Memory in `setCountry::BriVault`
Root + Impact : setCountry::BriVault function is using memory instead of calldata which will save gas fee
Description
-
The function
setCountryhavestring[48] memory countrieswhich is consuming extra gas fee. -
The function is not modifing the
countriesstring array and is only reading from the array . -
Hence, it's a waste of gas to use
memorywhere the function only reading and is also not used anywhere in the contract, hence should also be made external with this .
contract BriVault is ERC4626, Ownable {
...
@> function setCountry(string[48] memory countries) public onlyOwner {
for (uint256 i = 0; i < countries.length; ++i) {
teams[i] = countries[i];
}
emit CountriesSet(countries);
}
...
}
Risk
Likelihood: Low
Impact: Low/Gas
Recommended Mitigation
Change
memory->calldataand also change the visbility specifier toexternal.
contract BriVault is ERC4626, Ownable {
...
- function setCountry(string[48] memory countries) public onlyOwner {
+ function setCountry(string[48] calldata countries) external onlyOwner {
for (uint256 i = 0; i < countries.length; ++i) {
teams[i] = countries[i];
}
emit CountriesSet(countries);
}
...
}
Updates
Appeal created
bube 19 days ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Gas optimizations
Gas optimizations are invalid according to the CodeHawks documentation.
Rewards breakdown
nSLOC
193This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.