Submission Details
Impact:
Likelihood:
Storage Array Length not Cached in `setCountry::BriVault`
Root + Impact :Calling .length inside of loop of expensive, wasting gas.
Description
In the function
setCountry::BriVault, use ofcountries.lengthis expensive and waste unnecessary gas.
contract BriVault is ERC4626, Ownable {
...
function setCountry(string[48] memory countries) public onlyOwner {
@> for (uint256 i = 0; i < countries.length; ++i) {
teams[i] = countries[i];
}
emit CountriesSet(countries);
}
...
}
Risk
Likelihood: Low
Impact: Low/Gas
Recommended Mitigation
Store the value of
countries.lengthoutside the loop in a local variablecountryLength.
contract BriVault is ERC4626, Ownable {
...
function setCountry(string[48] memory countries) public onlyOwner {
- for (uint256 i = 0; i < countries.length; ++i) {
+ uint256 countriesLength=countries.length;
+ for (uint256 i = 0; i < countriesLength; ++i) {
teams[i] = countries[i];
}
emit CountriesSet(countries);
}
...
}
Updates
Appeal created
bube 19 days ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Gas optimizations
Gas optimizations are invalid according to the CodeHawks documentation.
Rewards breakdown
nSLOC
193This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.