Submission Details
Impact:
Likelihood:
Storage Array Length not Cached in `_getWinnerShares::BriVault`
Root + Impact :Calling .length inside of loop of expensive, wasting gas.
Description
In the function
_getWinnerShares::BriVault, use ofuserAddress.lengthis expensive and waste unnecessary gas.
contract BriVault is ERC4626, Ownable {
...
function _getWinnerShares() internal returns (uint256) {
@> for (uint256 i = 0; i < usersAddress.length; ++i) {
address user = usersAddress[i];
totalWinnerShares += userSharesToCountry[user][winnerCountryId];
}
return totalWinnerShares;
}
...
}
Risk
Likelihood: Low
Impact: Low/Gas
Recommended Mitigation
Store the value of
userAddress.lengthoutside the loop in a local variableuserAddressLength.
contract BriVault is ERC4626, Ownable {
...
function _getWinnerShares() internal returns (uint256) {
- for (uint256 i = 0; i < usersAddress.length; ++i) {
+ uint256 userAddressLength=userAddress.length;
+ for (uint256 i = 0; i < userAddressLength; ++i) {
address user = usersAddress[i];
totalWinnerShares += userSharesToCountry[user][winnerCountryId];
}
return totalWinnerShares;
}
...
}
Updates
Appeal created
bube 19 days ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Gas optimizations
Gas optimizations are invalid according to the CodeHawks documentation.
Rewards breakdown
nSLOC
193This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.