Submission Details
Impact:
Likelihood:
Return value from `_getWinnerShares::BriVault` is not used anywhere in the contract
Root + Impact : _getWinnerShares::BriVault is returning uint256 but the return value is not used in the contract anywhere, wasting gas fee.
Description
In the function
_getWinnerShares::BriVault,the return value is not used anywhere this function is being called and is an internal function, so it's a waste of gas fee.
contract BriVault is ERC4626, Ownable {
...
@> function _getWinnerShares() internal returns (uint256) {
for (uint256 i = 0; i < usersAddress.length; ++i) {
address user = usersAddress[i];
totalWinnerShares += userSharesToCountry[user][winnerCountryId];
}
@> return totalWinnerShares;
}
...
}
Risk
Likelihood: Low
Impact: Low
Recommended Mitigation
Remove the
returnvalue and thereturns(uint256)from the main function signature.
contract BriVault is ERC4626, Ownable {
...
- function _getWinnerShares() internal returns (uint256) {
+ function _getWinnerShares() internal{
for (uint256 i = 0; i < usersAddress.length; ++i) {
address user = usersAddress[i];
totalWinnerShares += userSharesToCountry[user][winnerCountryId];
}
- return totalWinnerShares;
}
...
}
Updates
Appeal created
bube 19 days ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Gas optimizations
Gas optimizations are invalid according to the CodeHawks documentation.
Rewards breakdown
nSLOC
193This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.