Table of Contents

• Summary

  • Files Summary

  • Files Details

  • Issue Summary

• Low Issues

  • L-1: Centralization Risk

  • L-2: Unspecific Solidity Pragma

  • L-3: Address State Variable Set Without Checks

  • L-4: Public Function Not Used Internally

  • L-5: Empty require() / revert() Statement

  • L-6: PUSH0 Opcode

  • L-7: Modifier Invoked Only Once

  • L-8: Large Numeric Literal

  • L-9: Unused Error

  • L-10: Local Variable Shadows State Variable

  • L-11: Storage Array Length not Cached

  • L-12: Costly operations inside loop

  • L-13: State Variable Could Be Immutable

  • L-14: Unchecked Return

Low Issues

L-1: Centralization Risk

Contracts have owners with privileged rights to perform admin tasks and need to be trusted to not perform malicious updates or drain funds.

L-2: Unspecific Solidity Pragma

Consider using a specific version of Solidity in your contracts instead of a wide version. For example, instead of pragma solidity ^0.8.0;, use pragma solidity 0.8.0;

L-3: Address State Variable Set Without Checks

Check for address(0) when assigning values to address state variables.

L-4: Public Function Not Used Internally

If a function is marked public but is not used internally, consider marking it as external.

L-5: Empty require() / revert() Statement

Use descriptive reason strings or custom errors for revert paths.

L-6: PUSH0 Opcode

Solc compiler version 0.8.20 switches the default target EVM version to Shanghai, which means that the generated bytecode will include PUSH0 opcodes. Be sure to select the appropriate EVM version in case you intend to deploy on a chain other than mainnet like L2 chains that may not support PUSH0, otherwise deployment of your contracts will fail.

L-7: Modifier Invoked Only Once

Consider removing the modifier or inlining the logic into the calling function.

L-8: Large Numeric Literal

Large literal values multiples of 10000 can be replaced with scientific notation.Use e notation, for example: 1e18, instead of its full numeric value.

L-9: Unused Error

Consider using or removing the unused error.

L-10: Local Variable Shadows State Variable

Rename the local variable that shadows another state variable.

L-11: Storage Array Length not Cached

Calling .length on a storage array in a loop condition is expensive. Consider caching the length in a local variable in memory before the loop and reusing it.

L-12: Costly operations inside loop

Invoking SSTORE operations in loops may waste gas. Use a local variable to hold the loop computation result.

L-13: State Variable Could Be Immutable

State variables that are only changed in the constructor should be declared immutable to save gas. Add the immutable attribute to state variables that are only changed in the constructor

L-14: Unchecked Return

Function returns a value but it is ignored. Consider checking the return value.