Submission Details
Impact:
Likelihood:
Unnecessary timestamp check inside `_setFinallizedVaultBalance::BriVault` function
Root + Impact : _setFinallizedVaultBalance::BriVault is an internal function which is only called inside one function(i.e. setWinner), which also has the eventEndDate timestamp Check, hence check inside _setFinallizedVaultBalance is wasting gas.
Description
-
setWinnerfunction already has a check forblock.timestamp<=eventEndDate,inside_setFinallizedVaultBalancetimestamp check forblock.timestamp<=eventStartDateis of no use . -
Since,
setWinneris checking foreventEndDate, the check foreventStartDateis already covered in it.
contract BriVault is ERC4626, Ownable {
...
function setWinner(uint256 countryIndex) public onlyOwner returns (string memory) {
if (block.timestamp <= eventEndDate) {
revert eventNotEnded();
}
require(countryIndex < teams.length, "Invalid country index");
if (_setWinner) {
revert WinnerAlreadySet();
}
winnerCountryId = countryIndex;
winner = teams[countryIndex];
_setWinner = true;
_getWinnerShares();
_setFinallizedVaultBalance();
emit WinnerSet(winner);
return winner;
}
...
function _setFinallizedVaultBalance() internal returns (uint256) {
@> if (block.timestamp <= eventStartDate) {
@> revert eventNotStarted();
@> }
return finalizedVaultAsset = IERC20(asset()).balanceOf(address(this));
}
...
...
}
Risk
Likelihood: Low
Impact: Low/Gas
Recommended Mitigation
Remove the check inside
_setFinallizedVaultBalance,which is already covered insidegetWinnerfunction .
contract BriVault is ERC4626, Ownable {
...
function setWinner(uint256 countryIndex) public onlyOwner returns (string memory) {
if (block.timestamp <= eventEndDate) {
revert eventNotEnded();
}
require(countryIndex < teams.length, "Invalid country index");
if (_setWinner) {
revert WinnerAlreadySet();
}
winnerCountryId = countryIndex;
winner = teams[countryIndex];
_setWinner = true;
_getWinnerShares();
_setFinallizedVaultBalance();
emit WinnerSet(winner);
return winner;
}
...
function _setFinallizedVaultBalance() internal returns (uint256) {
- if (block.timestamp <= eventStartDate) {
- revert eventNotStarted();
- }
return finalizedVaultAsset = IERC20(asset()).balanceOf(address(this));
}
...
...
}
Rewards breakdown
nSLOC
193This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.