Submission Details
Impact:
Likelihood:
`ReFiSwapRebateHook::ChangeFee` does not emit event after protocol state is changed
Root + Impact
Description
An event should be emitted once a state of the protocol is changed, but no events were emitted.
function ChangeFee(bool _isBuyFee, uint24 _buyFee, bool _isSellFee, uint24 _sellFee) external onlyOwner {
@> if (_isBuyFee) buyFee = _buyFee;
@> if (_isSellFee) sellFee = _sellFee;
}
Risk
Likelihood:
The issue occurs every time an owner changes fee.
Impact:
No data is provided by the protocol to any concerned third-party, reducing on-chain observability and making it harder for off-chain indexers, UIs, and auditors to track history.
Proof of Concept
function ChangeFee(bool _isBuyFee, uint24 _buyFee, bool _isSellFee, uint24 _sellFee) external onlyOwner {
@> if (_isBuyFee) buyFee = _buyFee;
@> if (_isSellFee) sellFee = _sellFee;
}
Recommended Mitigation
Add events and emit them
+event BuyFeeChanged(uint24 buyFee);
+event SellFeeChanged(uint24 sellFee);
function ChangeFee(bool _isBuyFee, uint24 _buyFee, bool _isSellFee, uint24 _sellFee) external onlyOwner {
- if (_isBuyFee) buyFee = _buyFee;
+ if (_isBuyFee) {
+ buyFee = _buyFee;
+ emit BuyFeeChanged(buyFee);
+ }
- if (_isSellFee) sellFee = _sellFee;
+ if (_isSellFee) {
+ sellFee = _sellFee;
+ emit SellFeeChanged(sellFee);
+ }
}
Rewards breakdown
nSLOC
150This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.