Submission Details
Impact:
Likelihood:
Duplicate Logic Statement Causing Misunderstanding
Description
The
RebateFiHook.sol::_beforeInitialize()function contains a duplicate logic check in theifstatement and can be safely removed.
function _beforeInitialize(address, PoolKey calldata key, uint160) internal view override returns (bytes4) {
if (Currency.unwrap(key.currency1) != ReFi &&
@> Currency.unwrap(key.currency1) != ReFi) {
revert ReFiNotInPool();
}
return BaseHook.beforeInitialize.selector;
}
Risk
Likelihood:
High as this duplicated check is always evaluated, though it does not affect the contract's behaviour.
Impact:
Low as this is a code quality issue with no direct impact on functionality or security.
Proof of Concept
Past the following into a test contract and run forge test --mt testCall in the terminal.
contract PoC is Test {
address constant ReFiTest = address(0x123);
function _beforeInitializeTest(address currencyx1) internal pure returns (bool) {
if (currencyx1 != ReFiTest && currencyx1 != ReFiTest) {
revert("ReFiNotInPool");
}
return true;
}
function testCall() external pure {
assertTrue(_beforeInitializeTest(ReFiTest));
}
}
Recommended Mitigation
Refactor the function to remove the duplicate condition, as shown below, to improve readability and maintainability.
function _beforeInitialize(address, PoolKey calldata key, uint160) internal view override returns (bytes4) {//@audit-issue no checking of parameters
- if (Currency.unwrap(key.currency1) != ReFi &&
- Currency.unwrap(key.currency1) != ReFi) {
+ if (Currency.unwrap(key.currency1) != ReFi) {
revert ReFiNotInPool();
}
return BaseHook.beforeInitialize.selector;
}
Rewards breakdown
nSLOC
150This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.