RebateFi Hook

First Flight #53
Beginner FriendlyDeFi
100 EXP
View results
Submission Details
Impact: low
Likelihood: medium
Invalid

Potential Reentrancy in Withdraw

Description

  • While the withdrawal function follows the checks-effects-interactions pattern and uses standard ERC20 transfers, it remains potentially vulnerable to reentrancy attacks if the token contract implements callback mechanisms or unusual transfer behavior.

function withdrawTokens(address token, address to, uint256 amount) external onlyOwner {
IERC20(token).transfer(to, amount);
emit TokensWithdrawn(to, token , amount);
}

Risk

Impact:

  • Low risk with standard ERC20 implementations

  • Potential issues with ERC777 or similar tokens


Recommended Mitigation

function withdrawTokens(address token, address to, uint256 amount) external onlyOwner {
+ // Consider reentrancy guard for extra safety
IERC20(token).transfer(to, amount);
emit TokensWithdrawn(to, token , amount);
}
Updates

Lead Judging Commences

chaossr Lead Judge 12 days ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!