RebateFi Hook

First Flight #53
Beginner FriendlyDeFi
100 EXP
View results
Submission Details
Severity: low
Valid

Out-of-order parameters in the TokensWithdrawn event

Description

The parameters in the TokensWithdrawn Event are out of order.

Impact

The out-of-order parameters can reflect wrong data being emitted by the RebateFiHook.

Proof of concept

In line 44, we have this parameter order: token, to, and amount
.

event TokensWithdrawn(address indexed token, address indexed to, uint256 amount);

But on line 75, we have other parameters in order: to, token, and amount

emit TokensWithdrawn(to, token , amount);

Recommended Mitigation

Fix the TokensWithdrawn event emit:

- emit TokensWithdrawn(to, token , amount);
+ emit TokensWithdrawn(token, to , amount);
Updates

Lead Judging Commences

chaossr Lead Judge 12 days ago
Submission Judgement Published
Validated
Assigned finding tags:

Swapped token and to parameters in TokensWithdrawn event.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!