Submission Details
Impact:
Likelihood:
Proposal creation is restricted to owner (deployer) but the documentation says signers can propose
Author Revealed upon completion
Root + Impact
Description
Any signer with SIGNING_ROLE should be able to create a proposal
The proposeTransaction function applies the onlyOwner modifier instead of onlyRole
function proposeTransaction(...)
external
nonReentrant
noneZeroAddress(to)
@> onlyOwner
returns (uint256)
{
// ...;
}
Risk
Likelihood:
Anytime a new proposal is to be created
Impact:
-
Signers cannot create proposal
-
Multi-sig assumptions are broken
Proof of Concept
There is no need for a PoC here
Recommended Mitigation
Replace onlyOwner with onlyRole(SIGNING_ROLE)
function proposeTransaction(address to, uint256 value, bytes calldata data)
external
nonReentrant
noneZeroAddress(to)
- onlyOwner
+ onlyRole(SIGNING_ROLE)
returns (uint256)
{
return _proposeTransaction(to, value, data);
}
Rewards breakdown
nSLOC
205This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.
Rewards Distribution
The contest is complete and the rewards are being distributed.