MultiSig Timelock

First Flight #55
Beginner FriendlyWallet
100 EXP
Submission Details
Impact: low
Likelihood: low

Missing Getter function for NO_TIME_DELAY

Author Revealed upon completion

Description

The contract defines a private constant NO_TIME_DELAY with a value of 0, which represents the timelock duration for transactions below 1 ETH. While getter functions are provided for other timelock constants like (ONE_DAY_TIME_DELAY, TWO_DAYS_TIME_DELAY, and SEVEN_DAYS_TIME_DELAY), there is no public getter for NO_TIME_DELAY. This creates an inconsistency in the public contract interface and slightly reduces clarity for external consumers such as frontends, scripts, and auditors.


Impact

The absence of a getter function it reduces API completeness and transparency, requiring external consumers to implicitly assume that the zero-delay case corresponds to 0, rather than querying it directly from the contract.


Recommended Mitigation

For API symmetry and improved clarity, consider adding a getter function for the zero-delay constant:

function getNoTimeDelay() external pure returns (uint256) {
return NO_TIME_DELAY;
}

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!