MultiSig Timelock

First Flight #55
Beginner FriendlyWallet
100 EXP
Submission Details
Impact: low
Likelihood: high

proposeTransaction not matching requirements

Author Revealed upon completion

Root + Impact

Description

  • Based on the spec : Signers can 'Propose new transactions (permission is tied to the role, so any signer can propose)'

  • on proposeTransaction function, there is an onlyOwner validation, which violates the spec

Risk

Likelihood: High

  • considering there should be 5 user who can proposeTransaction, the chance of this occured is 4 out of 5 (80%)

Impact: low

  • no direct issue to the fund

Recommended Mitigation

function proposeTransaction(address to, uint256 value, bytes calldata data)
external
nonReentrant
noneZeroAddress(to)
onlyOwner - remove this code
onlyRole(SIGNING_ROLE) + add this code
returns (uint256)
{
return _proposeTransaction(to, value, data);
}

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!