Submission Details
Severity:
Missing mint/burn Transfer events
Description
The documentation states token will behave like an OpenZeppelin ERC20, but its implementation does not emit Transfer events on _mint() and _burn(), whereas OpenZeppelin’s _mint() and _burn() always emit Transfer(address(0), to, amount) and Transfer(from, address(0), amount)`
Recommended Mitigation
Updating the token’s mint and burn to follow the OpenZeppelin ERC20
function _mint(...) internal {
//...
mstore(ptr, value)
log3(
ptr,
0x20,
0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef,
mload(0x60),
account)
}
function _burn(...) internal {
//...
mstore(ptr, value)
log3(
ptr,
0x20,
0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef,
account,
mload(0x60))
}
Updates
Lead Judging Commences
gaurangbrdv 19 days ago
Submission Judgement Published Assigned finding tags:
missing event
missing event emission
Rewards breakdown
nSLOC
222This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.