Non-Standard Internal Function Naming (totalSupply_) + Low

Description

• Normal behavior: Internal state variables in ERC-20 contracts use a leading underscore (e.g., _totalSupply) to indicate private/internal access. Standard practice is to access this variable directly internally.

Issue: The contract defines an internal function totalSupply_() to return the value of _totalSupply. This naming is confusing, non-standard, and unnecessary for internal use. Internal code should access _totalSupply directly.

Risk

Likelihood: Low

• Reason 1: Developers may call totalSupply_() unnecessarily instead of _totalSupply, creating confusion.

• Reason 2: Auditors or external tooling might misinterpret this internal function as part of the contract’s external API.

Impact: Low

• Impact 1: Confusion for maintainers or auditors.

• Impact 2: Minor unnecessary gas cost due to calling a function instead of reading the storage variable directly.

Proof of Concept

totalSupply_() is not a standard naming for the internal functions across the project.

Recommended Mitigation

Rename totalSupply_() function to _totalSupply() to follow the standard naming.