Submission Details
Impact:
Likelihood:
lastPhaseUpdateBlock State Variable Never Read
Author Revealed upon completion
Description
The
lastPhaseUpdateBlockstate variable is assigned during phase transitions but is never read anywhere in the contract.
uint256 public lastPhaseUpdateBlock; // @> Declared
function _beforeSwap(...) internal override returns (...) {
// ...
if (newPhase != currentPhase) {
_resetPerAddressTracking();
currentPhase = newPhase;
lastPhaseUpdateBlock = block.number; // @> Assigned but never read
}
// ...
}
Risk
Likelihood: N/A
Impact:
-
Wasted gas on storage writes
-
Misleading - suggests functionality that doesn't exist
-
Could be intended for off-chain monitoring but has no on-chain use
Proof of Concept
Grep for lastPhaseUpdateBlock - only written, never read.
Recommended Mitigation
Remove the variable, or use it for per-user phase reset logic.
Option 1: Remove if not needed
- uint256 public lastPhaseUpdateBlock;
function _beforeSwap(...) internal override returns (...) {
// ...
if (newPhase != currentPhase) {
_resetPerAddressTracking();
currentPhase = newPhase;
- lastPhaseUpdateBlock = block.number;
}
// ...
}
Option 2: Use it for reset logic (if intended)
function _beforeSwap(...) internal override returns (...) {
// ...
+ // Reset tracking if user's last swap was before this phase started
+ if (addressLastSwapBlock[sender] < lastPhaseUpdateBlock) {
+ addressSwappedAmount[sender] = 0;
+ addressLastSwapBlock[sender] = 0;
+ }
// ...
}
Rewards breakdown
nSLOC
273This contest has a flat reward structure with the following payouts:
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.
Rewards Distribution
The contest is complete and the rewards are being distributed.