Submission Details
Impact:
Likelihood:
[L-01] `totalPenaltyFeesCollected` Never Updated
Root + Impact
Description
The tracking variable for penalty fees is declared but never incremented.
Location: src/TokenLaunchHook.sol:51
uint256 public totalPenaltyFeesCollected; // Always remains 0
Risk
Likelihood: Every penalized swap leaves this value unchanged at 0.
Impact:
-
Cannot track protocol revenue from penalties
-
Misleading state variable
Proof of Concept
function test_PoC_L03_UnusedPenaltyTracking() public {
uint256 penaltiesBefore = hook.totalPenaltyFeesCollected();
// Do multiple rapid swaps to trigger cooldown penalties
for (uint256 i = 0; i < 5; i++) {
_swap(user1, 0.001 ether);
}
uint256 penaltiesAfter = hook.totalPenaltyFeesCollected();
// Penalties were applied (via feeOverride) but NOT tracked!
assertEq(penaltiesBefore, penaltiesAfter, "Penalty tracking never updated");
assertEq(penaltiesAfter, 0, "Always remains 0");
}
Recommendations
Remove if not needed, or implement proper tracking.
Rewards breakdown
nSLOC
273This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.