Submission Details
Impact:
Likelihood:
Code Sanity - Code Organization and Maintainability
Description
-
Functions must be placed under the right heading.
-
The function
getCurrentPhaseis wrongly placed under the headingINTERNAL FUNCTIONS -
Instead it must be placed under the heading
VIEW FUNCTIONS
/* ™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™ */
/* INTERNAL FUNCTIONS */
/* ™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™™ */
function _resetPerAddressTracking() internal {
addressSwappedAmount[address(0)] = 0;
addressLastSwapBlock[address(0)] = 0;
}
@> function getCurrentPhase() public view returns (uint256) {
if (launchStartBlock == 0) return 0;
uint256 blocksSinceLaunch = block.number - launchStartBlock;
if (blocksSinceLaunch < phase1Duration) {
return 1;
} else if (blocksSinceLaunch < phase1Duration + phase2Duration) {
return 2;
} else {
return 3;
}
}
Risk
Likelihood:
NA
An attacker cannot exploit this issue. This is related to "sanity" of code.
Impact:
This reduces the readability and "sanity" of the codebase. It hampers the ability of developers and auditors to quickly parse the contract's interface and internal logic.
Recommended Mitigation
Place the function getCurrentPhase under the heading VIEW FUNCTIONS.
Rewards breakdown
nSLOC
273This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.