Stratax Contracts

First Flight #57
Beginner FriendlyDeFi
100 EXP
Submission Details
Impact: low
Likelihood: low

Missing Input Validation in Stratax::recoverTokens Allows Invalid Parameters

Author Revealed upon completion

Missing Input Validation in Stratax::recoverTokens Allows Invalid Parameters

Description:
Stratax::recoverTokens does not validate the inputs _token and _amount:

function recoverTokens(address _token, uint256 _amount) external onlyOwner {
IERC20(_token).transfer(owner, _amount);
}

This allows:

  • _token == address(0) (will revert or behave unexpectedly)

  • _amount == 0 (no-op calls that may hide operator mistakes)

Impact:
Low. This is mainly an operational robustness issue that can lead to misconfiguration calls and confusing behavior during emergency recovery.

Recommended Mitigation:
Add basic parameter checks:

function recoverTokens(address _token, uint256 _amount) external onlyOwner {
+ require(_token != address(0), "Invalid token");
+ require(_amount > 0, "Invalid amount");
IERC20(_token).transfer(owner, _amount);
}

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!