Submission Details
Impact:
Likelihood:
[I-1] Payable functions are not supposed to receive Ether
Author Revealed upon completion
Payable functions are not supposed to receive Ether
Description
The 2 functions mintNft and buy are marked as payable, but they are not supposed to receive any Ether. All the payments are processed in USDC. The keyword can be removed to prevent users from sending Ether to the smart contract.
@> function mintNft() external payable onlyWhenRevealed onlyWhitelisted {
@> function buy(uint256 _listingId) external payable {
Recommended Mitigation
Remove the payable keyword:
- function mintNft() external payable onlyWhenRevealed onlyWhitelisted {
+ function mintNft() external onlyWhenRevealed onlyWhitelisted {
- function buy(uint256 _listingId) external payable {
+ function buy(uint256 _listingId) external {
Rewards breakdown
nSLOC
253This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.
Rewards Distribution
The contest is complete and the rewards are being distributed.