Submission Details
Impact:
Likelihood:
Redundant Code
Redundant Code
Description
The vulnerability is in
_price has already been checked in the first line.Therefore, the last _price check is redundant.
require(_price >= MIN_PRICE, "Price must be at least 1 USDC");
require(ownerOf(_tokenId) == msg.sender, "Not owner of NFT");
require(s_listings[_tokenId].isActive == false, "NFT is already listed");
require(_price > 0, "Price must be greater than 0");//_price has already been checked in the first line.
Recommended Mitigation
require(_price >= MIN_PRICE, "Price must be at least 1 USDC");
require(ownerOf(_tokenId) == msg.sender, "Not owner of NFT");
require(s_listings[_tokenId].isActive == false, "NFT is already listed");
- require(_price > 0, "Price must be greater than 0");
Updates
Lead Judging Commences
rubik0n 16 days ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
info
Rewards breakdown
nSLOC
253This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.