Submission Details
Impact:
Likelihood:
Unnecessary Self-Transfer Causing Gas Waste and Potential Reversion
Root + Impact
Description
In the
collectUsdcFromSellingfunction, the contract unnecessarily transfers fees to itself usingusdc.safeTransfer(address(this), fees). Since the USDC is already in the contract from the buy function, this self-transfer wastes gas and could potentially cause unexpected reverts if the USDC token implementation doesn't handle self-transfers properly.
function collectUsdcFromSelling(uint256 _listingId) external onlySeller(_listingId) {
Listing memory listing = s_listings[_listingId];
require(!listing.isActive, "Listing must be inactive to collect USDC");
uint256 fees = _calculateFees(listing.price);
uint256 amountToSeller = listing.price - fees;
uint256 collateralToReturn = collateralForMinting[listing.tokenId];
totalFeesCollected += fees;
amountToSeller += collateralToReturn;
usdc.safeTransfer(address(this), fees); // @ self transfer
usdc.safeTransfer(msg.sender, amountToSeller);
}
Risk
Impact
This causes unnecessary gas consumption and could lead to transaction failures if the USDC implementation reverts on self-transfers.
Proof of Concept
no need
Recommended Mitigation
function collectUsdcFromSelling(uint256 _listingId) external onlySeller(_listingId) {
Listing memory listing = s_listings[_listingId];
require(!listing.isActive, "Listing must be inactive to collect USDC");
uint256 fees = _calculateFees(listing.price);
uint256 amountToSeller = listing.price - fees;
uint256 collateralToReturn = collateralForMinting[listing.tokenId];
totalFeesCollected += fees;
amountToSeller += collateralToReturn;
- usdc.safeTransfer(address(this), fees); // @ self transfer
usdc.safeTransfer(msg.sender, amountToSeller);
}
Updates
Lead Judging Commences
rubik0n 16 days ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
info
Rewards breakdown
nSLOC
253This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.