SNARKeling Treasure Hunt

First Flight #59
Beginner FriendlyGameFiFoundry
100 EXP
Submission Details
Impact: high
Likelihood: high

Typo in 'claimed' check allows infinite replay of a single valid proof to drain the entire contract balance

Author Revealed upon completion

Root + Impact

Description

Normally, after a treasure is claimed using a valid ZK proof, the claimed mapping is updated to prevent the same treasureHash from being reused, protecting the contract from draining attacks.

However, in TreasureHunt.sol at line 88, there is a critical typo. The claim function checks claimed[_treasureHash] instead of checking the parameter treasureHash. Because _treasureHash is an uninitialized immutable private state variable, it strictly evaluates to bytes32(0). Thus, the replay check always evaluates claimed[bytes32(0)], which is always false.

This completely bypasses the replay protection. A single legitimate user or attacker with ONE valid proof can repeatedly call claim() to systematically drain the entire contract's ETH (e.g., 100 ETH) until claimsCount >= MAX_TREASURES is hit.

// Vulnerable code in contracts/src/TreasureHunt.sol line 88
if (claimed[_treasureHash]) revert AlreadyClaimed(treasureHash);

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!