BattleChain Confidence Pools

Summary

When creating a pool, initialize() only checks if the agreement is registered (isAgreementValid), but does not check the agreement's current state. A pool can be successfully deployed on an agreement already in CORRUPTED, PRODUCTION, or PROMOTION_REQUESTED state. Where staking is permanently blocked, resulting in a pool that is born dead.

Root Cause

While staking correctly blocks terminal states:

There is no matching guard at pool creation time.

Code Snippet-
https://github.com/CodeHawks-Contests/2026-07-bc-confidence-pools/blob/58e8ba4ce3f3277866e4926f3140e597f9554a1e/src/ConfidencePool.sol#L200

Impact

Pool deploys successfully but no one can ever stake on it.

Mitigation

Add agreement state check inside initialize() after the isAgreementValid check:

This ensures pools are only created on agreements where staking is still possible.