Submission Details
Impact:
Likelihood:
`_clampUserSums()` Called Unnecessarily in `withdraw()` Always a No-Op
Summary
withdraw() calls _clampUserSums(msg.sender) but this call always returns immediately without doing anything. The withdraw gate already guarantees riskWindowStart == 0 before execution reaches that line, and _clampUserSums returns early when riskWindowStart == 0. The call is a dead code path that only wastes gas.
Root Cause
withdraw() gate ensures riskWindowStart == 0:
function withdraw() external nonReentrant {
...
if (
riskWindowStart != 0 // reverts if riskWindowStart != 0
|| (...)
) {
revert WithdrawsDisabled();
}
// If we reach here: riskWindowStart is ALWAYS 0
_clampUserSums(msg.sender); // pointless call
}
_clampUserSums immediately returns when riskWindowStart == 0:
function _clampUserSums(address u) internal {
uint256 start = riskWindowStart;
uint256 stake_ = eligibleStake[u];
if (start == 0 || stake_ == 0) return; // ALWAYS hits this when called from withdraw()
// never reaches here from withdraw()
...
}
Impact
Wastes gas on every withdrawal (extra SLOAD for riskWindowStart).
Fix
Simply remove the unnecessary call.
Updates
Lead Judging Commences
inallhonesty 22 days ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
QA / Informational / Gas
inallhonesty 22 days ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
QA / Informational / Gas
Prize pool breakdown
Total prize
7.25 ETH
nSLOC
5890
ETH / LOC
6
1.25
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.