DatingDapp
AI First Flight #6
Beginner FriendlyFoundrySolidityNFT
EXP
View results
Previous Next
Submission Details
Impact: medium
Likelihood: high
Invalid

Code maturity is quite poor, the protocol do not provide commit hash for audit, could have new bugs in different commits

hmpippo

Code maturity is quite poor, the protocol do not provide commit hash for audit, could have new bugs in different commits

Description

  • Missing commit hash in scope

  • There's remappings error in foundry.toml

  • Test Coverage for MultiSigWallet and LikeRegistry is very low

remapping = [
"@openzeppelin//lib/openzeppelin-contracts/",
"forge-std/=/lib/forge-std/src/",
]

Risk

Likelihood: High

  • This is one hundred pecentage to happen!

Impact: Medium

  • Poor code maturity could result in a lot issues!

Proof of Concept

╭-----------------------------+-----------------+----------------+---------------+---------------╮
| File | % Lines | % Statements | % Branches | % Funcs |
+================================================================================================+
| src/LikeRegistry.sol | 5.00% (2/40) | 2.56% (1/39) | 0.00% (0/17) | 16.67% (1/6) |
|-----------------------------+-----------------+----------------+---------------+---------------|
| src/MultiSig.sol | 0.00% (0/32) | 0.00% (0/34) | 0.00% (0/23) | 0.00% (0/5) |
|-----------------------------+-----------------+----------------+---------------+---------------|
| src/SoulboundProfileNFT.sol | 93.55% (29/31) | 96.15% (25/26) | 55.56% (5/9) | 85.71% (6/7) |
|-----------------------------+-----------------+----------------+---------------+---------------|
| Total | 30.10% (31/103) | 26.26% (26/99) | 10.20% (5/49) | 38.89% (7/18) |
╰-----------------------------+-----------------+----------------+---------------+---------------╯

Recommended Mitigation

Provide the exact commit hash for audit, improve the code coverage etc.
And fix the remappings error in foundry.toml.

-remapping = [
- "@openzeppelin//lib/openzeppelin-contracts/",
- "forge-std/=/lib/forge-std/src/",
+remappings = [
+ "@openzeppelin/=lib/openzeppelin-contracts/",
+ "forge-std/=lib/forge-std/src/",
]
Updates

Lead Judging Commences

ai-first-flight-judge Lead Judge about 10 hours ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!