MyCut

AI First Flight #8
Beginner FriendlyFoundry
EXP
View results
Submission Details
Impact: low
Likelihood: low
Invalid

[L-5]: `Pot::i_players` and `Pot::i_rewards` are named incorrectly, leading to belief that they are `immutable`

[L-5]: Pot::i_players and Pot::i_rewards are named incorrectly, leading to belief that they are immutable

Description

The two arrays Pot::i_players and Pot::i_rewards are named with naming conventions that point to the variables being immutable, but they do not have that declaration.

@> address[] private i_players;
@> uint256[] private i_rewards;

Risk

Likelihood:

These variables will always be named incorrectly.

Impact:

Devs will be confused by the mismatch in naming convention, leading to unforeseen operations.

Proof of Concept

Recommended Mitigation

The variables should be renamed.

- address[] private i_players;
+ address[] private players;
- uint256[] private i_rewards;
+ uint256[] private rewards;
Updates

Lead Judging Commences

ai-first-flight-judge Lead Judge about 1 hour ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!