MyCut

AI First Flight #8
Beginner FriendlyFoundry
EXP
View results
Submission Details
Impact: low
Likelihood: low
Invalid

[L-01] — Misleading Constant Name `managerCutPercent`

[L-01] — Misleading Constant Name managerCutPercent

Severity: Low
File: src/Pot.sol
Line: 14

src/Pot.sol
L14: uint256 private constant managerCutPercent = 10; ← misleading name

Summary

managerCutPercent = 10 is used as remainingRewards / 10 (correctly yields 10%). Naming it "Percent" is misleading — if a future developer sets it to 50 expecting 50%, they'd get 2% (1/50). The name implies a percentage value but it acts as a denominator.


Recommendations

// src/Pot.sol — Line 14
- uint256 private constant managerCutPercent = 10;
+ uint256 private constant MANAGER_CUT_DENOMINATOR = 10; // 1/10 = 10%

Updates

Lead Judging Commences

ai-first-flight-judge Lead Judge 6 days ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!